SubAssetでも中を見れるように、デフォルトで AdvancedMode にする #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
Aug 24, 2021
ousttrue
commented
Santarh
previously approved these changes
Aug 25, 2021
| @@ -23,7 +23,10 @@ public override void OnGUI(MaterialEditor materialEditor, MaterialProperty[] pro | |||
|
|
|||
| using (new LabelScope("Editor Settings")) | |||
| { | |||
| var backup = GUI.enabled; | |||
| GUI.enabled = true; | |||
| PopupEnum<MToon10EditorEditMode>("Edit Mode", props[MToon10Prop.EditorEditMode], materialEditor); | |||
There was a problem hiding this comment.
PopupEnum は MaterialProperty に対して副作用があるので SubAsset を変更してしまうと思う。
とはいえ、あまり本質的なプロパティではないのでまあ大丈夫か
There was a problem hiding this comment.
dirty flag や undo に悪さするかもしれないので、UI の状態を Editor に移動できるか見てみます
ousttrue
changed the title
に変更しました |
ousttrue
changed the title
Santarh
approved these changes
Aug 25, 2021
| // UI | ||
| if (true /* TODO: mToon.IsAdvancedMode */) | ||
| { | ||
| yield return (MToon10Prop.EditorEditMode.ToUnityShaderLabName(), 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.