Refactoring GltfParser
#1076
Merged
Refactoring GltfParser
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
commented
Jun 27, 2021
| /// Ambiguous file parser. | ||
| /// Determine parsing method from the file extension. | ||
| /// </summary> | ||
| public sealed class AmbiguousGltfFileParser |
There was a problem hiding this comment.
従来の GltfParser 相当に、ファイルパス拡張子から判断してパース方法を変えるパーサ
| /// <summary> | ||
| /// .GLB file parser. | ||
| /// </summary> | ||
| public sealed class GlbFileParser |
There was a problem hiding this comment.
純粋に *.glb ファイルだけをパースするパーサ
| /// Low-level API. | ||
| /// Parse from specified path & specified binary. | ||
| /// </summary> | ||
| public sealed class GlbLowLevelParser |
There was a problem hiding this comment.
VRM 1.0 Importer におけるマイグレーション時など、ファイルパスとそのバイナリが異なる場合の直接指定パーサ
| } | ||
|
|
||
| protected virtual void ParseExternalChunks(byte[] bytes, IReadOnlyList<GlbChunk> chunks) | ||
| public static GltfData ParseGltf(string path, string json, IReadOnlyList<GlbChunk> chunks, IStorage storage, MigrationFlags migrationFlags) |
| /// <summary> | ||
| /// .GLTF file with resources in same directory parser. | ||
| /// </summary> | ||
| public sealed class GltfFileWithResourceFilesParser |
| /// For unit tests. | ||
| /// JSON string with storage parser. | ||
| /// </summary> | ||
| public sealed class JsonWithStorageParser |
| /// <summary> | ||
| /// Zip archived .GLTF file & resources parser. | ||
| /// </summary> | ||
| public sealed class ZipArchivedGltfFileParser |
There was a problem hiding this comment.
Zip された *.GLTF ファイルディレクトリのパーサ
ousttrue
reviewed
Jun 29, 2021
|
|
||
| namespace UniGLTF | ||
| { | ||
| public sealed class GltfData |
There was a problem hiding this comment.
GltfParser から別れた。
ImporterContext にはこいつを渡す。
ousttrue
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GltfParserが、パース方法とパース結果の 2 つの責務を持っているのを分割。Assets/UniGLTF/Runtime/UniGLTF/IO/Parser/以下に分割してクラス化。*.glbや*.gltfや*.zipの違いが同じクラスに押し込められていたのも分割。GltfDataとして定義。ImporterContextが関心があるのはパース結果であるためGltfParserではなくGltfDataを引数に取る。インタフェースの変更が主なので
GltfDataが持つプロパティのアクセス修飾子などは変更していない。インタフェースの変更ではあるので、ユーザの API 呼び出し方法は変更される。
その点、この変更が良くなさそうであれば reject してください