UnityObjectDestoyer 改め RuntimeGltfInstance #1021

ousttrue · 2021-06-10T11:23:56Z

DisposeOnGameObjectDestroyed を廃止して、Load 関数から UnityObjectManager が返るようになった。これを Destroy することで関連リソースは開放される。
引き換えに ScriptedImporter のときのみ、UnityObjectManager から AssetImporter に移動するようになった

新しい使い方は以下のような感じ。

            // import
            using (var context = new ImporterContext(parser))
            using (var loaded = context.Load()) // すぐ削除する場合。
            {
                loaded.ShowMeshes(); // ImorterContext から移動した
                loaded.EnableUpdateWhenOffscreen(); // ImorterContext から移動した
            }

インタフェース。デストロイすべき UnityEngine.Object をため込む

    public interface IResponsibilityForDestroyObjects : IDisposable
    {
        void TransferOwnership(TakeResponsibilityForDestroyObjectFunc take);
    }

GameObject(prefab root)の移譲の判定にしか使っていなかった。設計変更で不要になった

Santarh

よさそう！
名称だけ…

Santarh · 2021-06-11T07:29:17Z

Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/EditorAnimation.cs

@@ -21,7 +21,7 @@ public static void OnGUIAnimation(ScriptedImporter importer, GltfParser parser)
                }
            }

-            importer.DrawRemapGUI<AnimationClip>(parser.GLTF.animations.Select(x => new SubAssetKey(typeof(AnimationClip), x.name)));
+            importer.DrawRemapGUI<AnimationClip>(AnimationImporterUtil.EnumerateSubAssetKeys(parser.GLTF));


Santarh · 2021-06-11T07:38:06Z

Assets/VRMShaders/GLTF/IO/Runtime/UnityObjectDestroyer.cs

+{
+    public static class UnityObjectDestoyer
+    {
+        public static void DestroyRuntimeOrEditor(UnityEngine.Object o)


Santarh · 2021-06-11T07:44:12Z

Assets/VRMShaders/GLTF/IO/Runtime/IResponsibilityForDestroyObjects.cs

+    /// TransferOwnership により、破棄責任を移譲することができる。
+    /// 
+    /// </summary>
+    public interface IResponsibilityForDestroyObjects : IDisposable


よさそう

これも名前がもうひとひねりほしい気がするが、思いつかない……
長ったらしく書くと、このインタフェースを実装するクラスの責務は「所有権を持つ UnityEngine.Object を移譲することができる」だと思うのだが、う～ん…

Santarh · 2021-06-11T07:45:21Z

Assets/UniGLTF/Runtime/UniGLTF/UnityObjectManager.cs

+    /// <summary>
+    /// Mesh, Material, Texture などを抱えておいて確実に破棄できるようにする
+    /// </summary>
+    public class UnityObjectManager : MonoBehaviour, IResponsibilityForDestroyObjects


存在はいい！が名前が…う～ん…

ユーザの期待としては Load API の返り値は「ロードした glTF/VRM モデルそのもの」だと思うので、そういう名称にしてしまっていいと思う。
ModelInstance とか glTFModel とか

インスタンスの変数名も loaded じゃなくて loadedModel とか model でよさそう

Santarh · 2021-06-11T07:47:39Z

Assets/UniGLTF/Runtime/UniGLTF/UnityObjectManager.cs

+
+        public void Dispose()
+        {
+            UnityObjectDestoyer.DestroyRuntimeOrEditor(this);


this.gameObject を Destroy すべきかも

たしかに！

Santarh · 2021-06-11T08:16:33Z

サンプルコードもいずれ合わせて要修正
https://vrm.dev/docs/univrm/programming/runtime_import/

Santarh

LGTM

Santarh · 2021-06-11T08:18:46Z

Assets/UniGLTF/Runtime/UniGLTF/IO/ImporterContext.cs

@@ -61,7 +61,7 @@ public class ImporterContext : IResponsibilityForDestroyObjects
        };

        #region Load. Build unity objects
-        public virtual async Task<UnityObjectManager> LoadAsync(IAwaitCaller awaitCaller = null, Func<string, IDisposable> MeasureTime = null)
+        public virtual async Task<RuntimeGltfInstance> LoadAsync(IAwaitCaller awaitCaller = null, Func<string, IDisposable> MeasureTime = null)


よさそう！

Santarh · 2021-06-11T08:18:56Z

Assets/UniGLTF/Runtime/UniGLTF/RuntimeGltfInstance.cs

    /// </summary>
-    public class UnityObjectManager : MonoBehaviour, IResponsibilityForDestroyObjects
+    public class RuntimeGltfInstance : MonoBehaviour, IResponsibilityForDestroyObjects


よさそう！

Santarh · 2021-06-11T08:19:04Z

Assets/UniGLTF/Runtime/UniGLTF/RuntimeGltfInstance.cs

+        /// <summary>
+        /// this is UniGLTF root gameObject
+        /// </summary>
+        public GameObject Root => this.gameObject;


よさそう！

Santarh · 2021-06-11T08:19:10Z

Assets/UniGLTF/Runtime/UniGLTF/RuntimeGltfInstance.cs

@@ -58,7 +64,7 @@ public void TransferOwnership(TakeResponsibilityForDestroyObjectFunc take)

        public void Dispose()
        {
-            UnityObjectDestoyer.DestroyRuntimeOrEditor(this);
+            UnityObjectDestoyer.DestroyRuntimeOrEditor(this.gameObject);


よさそう！

ousttrue requested a review from Santarh June 10, 2021 11:23

ousttrue changed the title ~~UnityObjectDestoyer 改め UnityObjectManager~~ [WIP] UnityObjectDestoyer 改め UnityObjectManager Jun 10, 2021

ousttrue added 8 commits June 10, 2021 20:39

IResponsibilityForDestroyObjects

6268ec8

add SubAssetKey to TakeResponsibilityForDestroyObjectFunc

3b1f3fb

rename UnityResourceDestroyer to UnityObjectManager

aa6b826

ImporterContext.LoadAsync が UnityObjectManager を戻すようにインタフェースを変更

a17c789

UnityObjectManager から ScriptedImporter に移譲する

e9d4654

fix humanoid SubAssetKey

0bdd18c

TakeResponsibilityForDestroyObjectFunc の返り値削除

612a59c

GameObject(prefab root)の移譲の判定にしか使っていなかった。設計変更で不要になった

Dispose で Destory(this) する

81e02c8

ousttrue force-pushed the feature10/UnityObjectManager branch from 5efbcef to 81e02c8 Compare June 10, 2021 11:39

ousttrue changed the title ~~[WIP] UnityObjectDestoyer 改め UnityObjectManager~~ UnityObjectDestoyer 改め UnityObjectManager Jun 10, 2021

Santarh requested changes Jun 11, 2021

View reviewed changes

ousttrue added 3 commits June 11, 2021 17:02

Dispose gameobject

ac7e4cd

Root

4db1711

UnityObjectManager is not unnecessary for prefab

423889c

rename RuntimeGltfInstance

89276c2

Santarh approved these changes Jun 11, 2021

View reviewed changes

ousttrue requested a review from Santarh June 11, 2021 08:21

Santarh approved these changes Jun 11, 2021

View reviewed changes

ousttrue merged commit b871311 into vrm-c:master Jun 11, 2021

ousttrue changed the title ~~UnityObjectDestoyer 改め UnityObjectManager~~ UnityObjectDestoyer 改め RuntimeGltfInstance Jun 11, 2021

ousttrue deleted the feature10/UnityObjectManager branch October 27, 2021 06:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UnityObjectDestoyer 改め RuntimeGltfInstance #1021

UnityObjectDestoyer 改め RuntimeGltfInstance #1021

ousttrue commented Jun 10, 2021 •

edited

Loading

Santarh left a comment

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

ousttrue Jun 11, 2021

Santarh commented Jun 11, 2021

Santarh left a comment

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

Santarh Jun 11, 2021

UnityObjectDestoyer 改め RuntimeGltfInstance #1021

UnityObjectDestoyer 改め RuntimeGltfInstance #1021

Conversation

ousttrue commented Jun 10, 2021 • edited Loading

Santarh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Santarh commented Jun 11, 2021

Santarh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ousttrue commented Jun 10, 2021 •

edited

Loading