-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent VRMSpringBoneColliderGroup
scaling behaviour
#673
Comments
The current SpringBone are implemented so that all nodes can be exported in a normalized state. In the future, we plan to fix it so that it works without normalization. |
For now, could a warning be added when exporting spring bone colliders without normalized nodes? I encountered this while investigating a report somebody made to me about colliders not working correctly. |
Implemented support for SpringBone collider scaling during normalization. |
Thank you, the collider is now exported the way it is shown! |
Describe the bug
The behaviour of the
VRMSpringBoneColliderGroup
does not seem to be consistent when first created in a game object with a scale not equal to 1, 1, 1. In the editor it scales along with object after setting it, even if this would lead to an inconsistent result (e.g. a collider in a 1, 1, 1 sphere with a radius of 0.5 shown to cover exact sphere). When exporting a scaled object with a collider on it, the radius of the collider seems to be divided by some component of the scale, even though it still shows the original value.To Reproduce
VRMSpringBoneColliderGroup
Expected behavior
The collider radius gives an absolute scale in world coordinates and is not influenced by the scaling of the object.
Screenshots
Original collider:
![ColliderBeforeExport](https://user-images.githubusercontent.com/38952746/104530013-5542c400-560b-11eb-97a0-272c2e404f8c.png)
Settings and gizmo after export:
![ColliderAfterExport](https://user-images.githubusercontent.com/38952746/104530017-57a51e00-560b-11eb-97c3-9a370bd82d11.png)
Comparison of both:
![ColliderAfterExportBoth](https://user-images.githubusercontent.com/38952746/104530020-596ee180-560b-11eb-9517-b381f4083f5a.png)
Comparison of both in play mode:
![ColliderAfterExportPlayback](https://user-images.githubusercontent.com/38952746/104530099-86bb8f80-560b-11eb-8cf4-e30e9dad4876.png)
The sphere arcs on both models have spring bones set to collide with the collider.
Environments (please complete the following information):
The text was updated successfully, but these errors were encountered: