Avoid failure on schedule metaparameter warning #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Could you please rebase and squash your commits. |
ghoneycutt
approved these changes
May 26, 2020
ffapitalle
force-pushed
the
avoid_failure_schedule_warning
branch
from
7396506 to
874106b
Compare
Great ! Done ! |
ghoneycutt
requested changes
May 26, 2020
There was a problem hiding this comment.
Realized tests are missing. Since this code is basically copying the tag functionality, you can copy those tests.
You will need a manifest in https://github.com/voxpupuli/puppet-syntax/tree/master/spec/fixtures/test_module/manifests
And copy these lines and change to match up with your new manifest.
|
Test is already here. |
ghoneycutt
approved these changes
May 26, 2020
|
Doh! Yes it is.. merging now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax checking was failing (exit code 1) when puppet raises a the following warning
Applied the same approach as
tag.