Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install setroubleshoot helpers #328

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Install setroubleshoot helpers #328

merged 2 commits into from
Oct 25, 2020

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Sep 23, 2020

Pull Request (PR) description

A sample set of methods to install setroubleshoot (and plugins).

Odds are this PR needs work, it is mostly a 'step one' towards seeing if this is a good fit here.

This Pull Request (PR) fixes the following issues

Fixes #327

kenyon
kenyon reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me. Just need tests.

manifests/package.pp Outdated Show resolved Hide resolved
@jcpunk
Copy link
Contributor Author

jcpunk commented Sep 23, 2020

Pushed up new version with unit tests.

kenyon
kenyon reviewed Sep 23, 2020
View reviewed changes
manifests/package.pp Outdated Show resolved Hide resolved
@jcpunk jcpunk requested a review from kenyon September 24, 2020 13:16
kenyon
kenyon reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like more work is needed to get the tests to pass.

spec/classes/selinux_package_spec.rb Outdated Show resolved Hide resolved
@bastelfreak bastelfreak added enhancement New feature or request tests-fail labels Sep 25, 2020
@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 5, 2020

I'm a bit confused why the tests are failing....

Shouldn't the spec tests be getting the defaults from Hiera if they are not set as params?

@jcpunk jcpunk requested a review from kenyon October 21, 2020 14:02
kenyon
kenyon approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcpunk have a look at my changes. I think this is what should be done. (I made them as separate commits so it's easy to see what I did, but we'll want to squash them on merge.)

@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 23, 2020

ahh, that makes sense when I look at it.

@kenyon kenyon removed the tests-fail label Oct 23, 2020
jcpunk and others added 2 commits October 24, 2020 21:15
@jcpunk @kenyon
add ability to install setroubleshoot packages
f9a0de9
@kenyon
refpolicy_package: fix puppet-lint warning
41ed27b 
"relative_classname_inclusion:WARNING:class included by absolute name
(::$class)"
@kenyon kenyon merged commit ceb4530 into voxpupuli:master Oct 25, 2020
@jcpunk jcpunk deleted the setroubleshoot branch October 26, 2020 13:14
EmRowlands pushed a commit to EmRowlands/puppet-selinux that referenced this pull request Mar 29, 2023
@kenyon
Merge pull request voxpupuli#328 from jcpunk/setroubleshoot
598d8bf 
Install setroubleshoot helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage setroubleshootd/sealert?
3 participants
@jcpunk @kenyon @bastelfreak