Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 26 uses the same package_name as Fedora 25 #218

Merged
merged 2 commits into from
May 4, 2017

Conversation

logic
Copy link
Contributor

@logic logic commented May 2, 2017

Fedora 26 is almost upon us (it's available today as an alpha release), and it uses the same package name as Fedora 25.

@juniorsysadmin
Copy link
Member

Would it be worth changing the match to be any Fedora version about a certain value, or is the history a good indicator that the value for 27 will change yet again?

Copy link
Contributor

@vinzent vinzent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we make 24 and upwards the default instead of failing with unsupported?

@oranenj
Copy link
Contributor

oranenj commented May 4, 2017

I agree with changing the default. That seems sensible.

It will fail anyway, if the package name changes.

@logic
Copy link
Contributor Author

logic commented May 4, 2017

It's technically legal to install a package named /usr/sbin/semange, which dnf will resolve to whatever package provides that, and I think puppet's package provider will do the right thing with it, but that's not exactly a common practice (and likely to surprise users of the module). ;)

I've updated the diff to make 24+ the new default, and removed the explicit failure.

@oranenj oranenj merged commit 339f830 into voxpupuli:master May 4, 2017
@oranenj
Copy link
Contributor

oranenj commented May 4, 2017

Thanks!

EmRowlands pushed a commit to EmRowlands/puppet-selinux that referenced this pull request Mar 29, 2023
Fedora 26 uses the same package_name as Fedora 25
cegeka-jenkins pushed a commit to cegeka/puppet-selinux that referenced this pull request Jan 10, 2025
Fedora 26 uses the same package_name as Fedora 25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants