Release checks fixes #113
Release checks fixes #113
Conversation
|
After a module like this one has been moved across to voxpupuli we normally do a modulesync using our own modulesync_config defaults (Gemfile, Rakefile etc). After this is done, you'll need to rebase and drop your Gemfile changes (unless it's something that should already be a default). Before then, if you need changes merged urgently, the best thing to do would be separate PRs that individually address the issues that you mentioned. Thanks! |
maage
force-pushed
the
release_checks-fixes
branch
3 times, most recently
from
3820f65 to
e7e210c
Compare
manifests/module.pp - WARNING: class included by relative name on line 40 This is also voxpupuli#101
And also format tests to use common base. When using ensure_package, ensure has value present, not installed. This fixes voxpupuli#112
enable_and_targeted.pp minimal.pp targeted.pp enable.pp disable.pp restorecond.pp mls.pp module.pp fcontext.pp fcontext_equals.pp rake aborted! .pp files present in tests folder; Move them to an examples folder following the new convention
maage
force-pushed
the
release_checks-fixes
branch
from
e7e210c to
34dff55
Compare
|
This is a lot of effort. I will merge this + do a modulesync afterwards. @maage Can you check our modulesync later just in case we kill any changes you made and need? |
|
okay I just realised that you did a modulesync here 👍 |
|
Thanks. Sorry about not communicating, I did not get pass from travis until I had to take last test. I'm not sure if my modulesync work is up to Vox Pupuli standards but at least many parts are what was there. I tried to save parts that were extended originally like extra lints and testing stuff. |
Small fixes to make rake release_checks pass and silence warnings and so on. I run my tests in Centos 7 and needed to fix some stuff too.
This should fix #101 and #112 .