Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources that use 'semanage' should have an autorequires on the various packages #345

Closed
trevor-vaughan opened this issue May 19, 2021 · 0 comments · Fixed by #346
Closed
Assignees

Comments

@trevor-vaughan
Copy link
Contributor

After using the latest release of the module, I noticed that selinux_port was having issues in some of my tests.

This turned out to be that (for whatever reason) the package containing the python semanage library had not yet been installed.

Instead of requiring users to include the entire module, I would like to propose that all commands that need semanage have an autorequires added on the various potential package names.

Unfortunately, this means that a failure in a package update will cascade but this is pretty standard and will fix potential 'dual-run' issues moving forward.

The main drawback is that, as new OS flavors are added, the package list will need to be updated to reflect things. I don't think that requiring the selinux::package class is a good idea because it contains more than the single package that is required for obtaining the semanage command.

@trevor-vaughan trevor-vaughan self-assigned this May 19, 2021
trevor-vaughan added a commit that referenced this issue May 19, 2021
Changed:

  * Added `autorequire` calls to ensure that the necessary packages are
    installed if `semanage` is to be used.

Closes #345
trevor-vaughan added a commit that referenced this issue May 20, 2021
Changed:

  * Added `autorequire` calls to ensure that the necessary packages are
    installed if `semanage` is to be used.

Closes #345
EmRowlands pushed a commit to EmRowlands/puppet-selinux that referenced this issue Mar 29, 2023
Changed:

  * Added `autorequire` calls to ensure that the necessary packages are
    installed if `semanage` is to be used.

Closes voxpupuli#345
cegeka-jenkins pushed a commit to cegeka/puppet-selinux that referenced this issue Jan 10, 2025
Changed:

  * Added `autorequire` calls to ensure that the necessary packages are
    installed if `semanage` is to be used.

Closes voxpupuli#345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant