Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hard require on epel for CentOS 7 #998

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ These are now documented via [Puppet Strings](https://github.com/puppetlabs/pupp

You can view example usage in [REFERENCE](REFERENCE.md).

**[puppet/epel](https://forge.puppet.com/modules/puppet/epel) is a soft dependency. The module requires it if you're on CentOS 7**
**[puppet/epel](https://forge.puppet.com/modules/puppet/epel) is a soft dependency. On CentOS, with `$repos_ensure` set to `false` (current default), it may be required.

Version v13.2.0 and older also added an erlang repository on CentOS 7. That isn't used and can be safely removed.

Expand Down
2 changes: 0 additions & 2 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,6 @@
default: {
}
}
} elsif ($facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '7') {
require epel
}

contain rabbitmq::install
Expand Down
9 changes: 8 additions & 1 deletion spec/acceptance/class_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@
context 'default class inclusion' do
let(:pp) do
<<-EOS
include rabbitmq
# Hack to make sure tests work w/ soft EPEL dependency on CentOS / EL7
if ($facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '7') {
include epel
include rabbitmq
Class['epel'] -> Class['rabbitmq']
} else {
include rabbitmq
}
EOS
end

Expand Down Expand Up @@ -111,7 +118,7 @@
end

describe port(25_672) do
xit 'Is on 55672 instead on older rmq versions' do

Check warning on line 121 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - CentOS 7

rabbitmq class: binding on all interfaces Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 121 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - CentOS 7

rabbitmq class: binding on all interfaces Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 121 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - Debian 10

rabbitmq class: binding on all interfaces Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 121 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - Debian 10

rabbitmq class: binding on all interfaces Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 121 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - Ubuntu 18.04

rabbitmq class: binding on all interfaces Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 121 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - Ubuntu 18.04

rabbitmq class: binding on all interfaces Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit
is_expected.to be_listening.on('0.0.0.0').with('tcp')
end
end
Expand Down Expand Up @@ -146,7 +153,7 @@
# This listens on all interfaces regardless of these settings

describe port(25_672) do
xit 'Is on 55672 instead on older rmq versions' do

Check warning on line 156 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - CentOS 7

rabbitmq class: binding to localhost only Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 156 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - CentOS 7

rabbitmq class: binding to localhost only Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 156 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - Debian 10

rabbitmq class: binding to localhost only Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 156 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - Debian 10

rabbitmq class: binding to localhost only Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 156 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - Ubuntu 18.04

rabbitmq class: binding to localhost only Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 156 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - Ubuntu 18.04

rabbitmq class: binding to localhost only Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit
is_expected.to be_listening.on('0.0.0.0').with('tcp')
end
end
Expand Down Expand Up @@ -211,7 +218,7 @@
end

describe port(25_672) do
xit 'Is on 55672 instead on older rmq versions' do

Check warning on line 221 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - CentOS 7

rabbitmq class: different management_ip_address and node_ip_address Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 221 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - CentOS 7

rabbitmq class: different management_ip_address and node_ip_address Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 221 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - Debian 10

rabbitmq class: different management_ip_address and node_ip_address Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 221 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - Debian 10

rabbitmq class: different management_ip_address and node_ip_address Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 221 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 8 - Ubuntu 18.04

rabbitmq class: different management_ip_address and node_ip_address Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit

Check warning on line 221 in spec/acceptance/class_spec.rb

View workflow job for this annotation

GitHub Actions / Puppet / Puppet 7 - Ubuntu 18.04

rabbitmq class: different management_ip_address and node_ip_address Port "25672" Is on 55672 instead on older rmq versions Skipped: Temporarily skipped with xit
is_expected.to be_listening.on('0.0.0.0').with('tcp')
end
end
Expand Down