Use data-in-modules instead of params.pp #797
Conversation
|
Do we really need to keep the |
|
I think it was already deprecated. Should be fine to pull it out. |
|
@wyardley Yes, I wanted to make sure that the default values are fetched correctly. |
|
@dhoppe Yeah, forgot there isn't really a task to do that automagically yet... :/ |
With voxpupuli/puppet-rabbitmq#797 merged e90dcbdeb3e8 which removed params.pp and server.pp Let's pin to the previous commit until this gets sorted out more carefully Example of a broken job: https://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039-master/0109c60/logs/overcloud-controller-0/var/log/journal.txt.gz#_May_13_03_24_41 Change-Id: I72306636fd7e49169790801f4fe5683bd0fabf0b
|
This should have been tagged as a breaking change. Previous parameter references have been used in control repos. |
|
Not much that can be done about it at this point almost a year later, even if that were the case, but I think params was always supposed to be private; I don’t think this breaks the documented suggested usage of this module. And the class was marked as private well before this version was released puppet-rabbitmq/manifests/params.pp Line 3 in 9924ca1 Vox overall does a pretty good job of tracking breaking changes, but this is a volunteer effort and an open spruce product, so these things will happen. |
|
Yes, I see that was added in 8.4.1 - however, we implemented this module prior to that. As a volunteer effort I pointed this out not to complain, but to help for future releases. Anyways, thanks for responding it is much appreciated. |
Use data-in-modules instead of params.pp
No description provided.