Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improved documentation of the ensure_repos parameter. #789

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

tobixen
Copy link
Contributor

@tobixen tobixen commented Apr 3, 2019

Pull Request (PR) description

This is a very simple suggestion on how to improve the documentation. It may be natural to assume that ensure_repos => True should fix erlang dependencies, a minor comment that it doesn't could be sufficient to avoid frustrations.

This pull request does not fix any issues, but does improve the situation wrg of #788.

@wyardley wyardley self-requested a review April 3, 2019 16:06
@wyardley wyardley added the docs Improvements or additions to documentation label Apr 3, 2019
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should include something in the README as well, but this is a good start. Thanks for the contribution!

@wyardley wyardley merged commit dd996ab into voxpupuli:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants