Release 8.5.0

[wyardley]

Pull Request (PR) description

Release 8.5.0

[bastelfreak]

Can we please include #761 before we do this release?

[wyardley]

Can we please include #761 before we do this release?

If it's breaking (meaning we have to go to 9.x), can we do it after, so that folks using older versions of Puppet can still get this bugfix?

[ghoneycutt]

If I'm understanding @wyardley correctly, +1 to tagging a release (not a -rc version) before dropping Puppet 4 in a major version change.

[travistie1]

Hi All, Is there any timeframe of when you will be deploying this 8.5.0 release to the Puppet Forge?
Just cause i need the fixes that you're releasing. I currently use Puppet 4.10.x and require the fixes for deploying & managing rabbitmq 3.7.9.

[wyardley]

I need to rebuild the changelog again. I can’t do it until about Sunday, tho it’s fine if someone else from Vox has a chance.

[travistie1]

I need to rebuild the changelog again. I can’t do it until about Sunday, tho it’s fine if someone else from Vox has a chance.

That's fine as long as i can get a Release next week some time that would be great.

Re-built changelog. If you have a sec, re-review please

[wyardley]

Sorry for the delay, this is ready for review if someone has a sec.

[ahmet2mir]

It seems that puppet 6 nightly build failed.

$ docker run --rm -it ubuntu:18.04 bash

root@6ae9bbeb2978:/# apt update
root@6ae9bbeb2978:/# apt install -y wget
root@6ae9bbeb2978:/# wget -O /tmp/puppet.deb http://nightlies.puppet.com/apt/puppet6-nightly-release-bionic.deb
root@6ae9bbeb2978:/# dpkg -i --force-all /tmp/puppet.deb
root@6ae9bbeb2978:/# apt update

root@6ae9bbeb2978:/# apt install puppet-agent
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Package puppet-agent is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'puppet-agent' has no installation candidate

[wyardley]

Yup, I can reproduce that locally and seems to affect other builds as well. I think it’s unrelated to our changes.

[korporationcl]

I need to rebuild the changelog again. I can’t do it until about Sunday, tho it’s fine if someone else from Vox has a chance.

That's fine as long as i can get a Release next week some time that would be great.

I'm actually waiting for this release too

[wyardley]

@bastelfreak do you want to approve these with the Puppet 6 nightly failures, or is there any progress on that issue?

[wyardley]

Thanks for everyone's patience. Some unrelated problems were causing those Travis failures.

https://forge.puppet.com/puppet/rabbitmq