Fixing puppet apt module requirement to < 6.0.0

[meltingrobot]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

[bastelfreak]

can you please update this to < 6.0.0? We always try to support the whole major release range.

[meltingrobot]

Okay, I think I fixed the commit to be 6.0.0 now.

[wyardley]

Puppet librarian shouldn't be looking at the spec_helper for acceptance tests, should it? I don't see an objection to merging this, but I don't see how it can help either. @bastelfreak?

I could see it installing deps from metadata but from spec_helper_acceptance?

[wyardley]

@meltingrobot can you squash that commit, if you know how?

[meltingrobot]

@wyardley I'm pretty sure it is the reason our Jenkins build is failing. When I did a grep through all the module files, that was the only place that the puppet-apt module was mentioned. Below is what I am seeing:

[Librarian] Conflict between puppetlabs-apt (< 5.0.0, >= 2.0.0) https://forgeapi.puppetlabs.com and puppetlabs-apt/5.0.1 https://forgeapi.puppetlabs.com

Not sure how to squash a commit, will look for directions to see if I can do that.

[wyardley]

I believe that file should be only looking at metadata.json and the like, but it will pull in sub dependencies and their dependencies. So it’s possible you have a module that depends on a module that depends on apt (btw, apt is supposed to be a soft dep, and shouldn’t be listed in metadata).

[meltingrobot]

Okay, I'm not sure how to squash a commit. I've read some guides, but I'm not sure what I'm doing on that.

[wyardley]

@meltingrobot maybe better not to do it on your master branch. Normally, in a feature branch, you could do something like git rebase -i HEAD~2, change pick to f (for fixup), then git push --force-with-lease. I'll just squash-merge this one, so don't worry about it.

Feel free to check out #voxpupuli on IRC / Slack if you have other questions.

I will go ahead and merge this, but I have a feeling a nested dependency might be your actual issue.

[meltingrobot]

@wyardley You were completely correct. It did not fix the issue. I discovered the real culprit after more research into the problem. It is actually the elastic-elasticsearch module for the 5.4.3 version we have that has a hard dependency of puppetlabs-apt (< 5.0.0, >= 2.0.0) I will look at updating that module to a 6.X version that drops that dependency. Thank you for your help.

[wyardley]

@meltingrobot Awesome, glad we figured that all out.