Ensure version fact does not throw an error for invalid match #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems sensible to me (though keep in mind that the module does use the version fact to determine some things about how it operates, so it may not operate correctly if the version is nil). Can you add a spec test test for a nil value with an invalid version value? |
dhollinger
requested changes
Jun 25, 2018
There was a problem hiding this comment.
As per @wyardley's request, please add/update the unit tests to account for your changes
wyardley
approved these changes
Jun 25, 2018
|
@dhollinger from my perspective, good to ship it |
dhollinger
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
If the
rabbitmq_versionstring returned fromrabbitmqadmin --versioncontains invalid characters it throws an error because the array is nil. This will make a empty array out of it so it won't throw an error in that case.This Pull Request (PR) fixes the following issues
Fixes #704