Install package via title, not name (#684) #686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the package resource accepting an array for
$title
, but not for the name parameter. I'm not sure why it was originally coded this way, but it seems to work with one more minor adjustment to the Arch tests (now that #685 is merged).It adds support in metadata.json for SLES 11 (only) to test the additional package we expect there. I didn't add support for SLES 12 or openSUSE because I'm not 100% sure about the versioning, and >=12 has systemd, so there are some additional adjustments needed there that should probably be done by someone who can do more testing and who knows the versioning situation (for example, we may not want to just do systemd based on >=12 because of the weird numbering w/ openSUSE).
Additionally, it slightly simplifies the resource requirement for the package(s) and moves them to
init.pp