add ability to have array as package name

[tampakrap]

in case the package has subpackages (like it does for the SUSE family
OSes)

[wyardley]

@tampakrap this makes some sense to me, will ask @bastelfreak to review as well.
Would you be able / willing to add / update SUSE support (update metadata, update params.pp) in another PR?

How are the packages broken up -- could you give an example of the packages that would make this work on SUSE, and does it vary by version?

[tampakrap]

Hello @wyardley thanks for the review.

Regarding packaging, there is a rabbitmq-server package with a -plugins subpackage, see https://build.opensuse.org/package/view_file/network:messaging:amqp/rabbitmq-server/rabbitmq-server.spec?expand=1

Regarding support, there is already support in params.pp and actually I use this module in production for quite some time now. I just noticed that SUSE is missing from metadata.json, I'd be happy to add it there as well in a separate PR

[wyardley]

I just noticed that SUSE is missing from metadata.json, I'd be happy to add it there as well in a separate PR

@tampakrap Yes, there's a section in params already. The module default is now to use vendor packages, so assuming we merge this to add support for multiple packages, I was suggesting that params should then be updated to install the correct packages (especially if the packages are broken up differently in different versions). Acceptance tests would be good too, though it doesn't look like we support SUSE acceptance tests currently (though you could propose the addition of some in https://github.com/voxpupuli/modulesync_config/tree/master/moduleroot/spec/acceptance/nodesets and https://github.com/voxpupuli/modulesync_config/tree/master/moduleroot/spec/acceptance/nodesets/docker)

Also, this PR should probably include a spec test for the multiple packages use case.

[bastelfreak]

Hi @tampakrap, thanks for this PR.

For any upcoming PRs: The goal is that the moduel works out of the box on a supported operating system. So it would be awesome if you could provide a PR with all data that you pass into the module to make it work on Suse. Would be nice to embed it into the params.pp

---

I don't think that a unit test is needed for this change

[wyardley]

@tampakrap Can you update https://github.com/voxpupuli/puppet-rabbitmq/blob/master/manifests/init.pp#L141 ? puppet strings will update the type, but should probably clarify that this can be a package name or a list of package names, especially since the variable is singular.

[tampakrap]

I added the subpackage in params.pp as @bastelfreak said which makes sens. @wyardley give me a hint on how this line should look like please and I'll do it as well

[wyardley]

@tampakrap sorry for the delayed response. Strings will take care of showing the allowed types, so it would just be to something like this:
# @param package_name Name(s) of the package(s) to install

[tampakrap]

thanks, I updated it

[wyardley]

Merged, thanks for the contribution.