-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow installation of rabbitmqadmin via package #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
reviewed
Oct 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe you could add some tests?
dhollinger
approved these changes
Oct 18, 2017
dhollinger
previously requested changes
Oct 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @wyardley said, needs some tests
bastelfreak
force-pushed
the
rabbitmqadmin
branch
from
October 18, 2017 22:32
4fc3f6a
to
2fad2ae
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-rabbitmq
that referenced
this pull request
Mar 26, 2021
allow installation of rabbitmqadmin via package
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Mar 30, 2022
Archlinux integration tests were failing because of rabbitmqadmin not being present. It seems that, while the package exists, it is in the "community" repo. Partially rolls back voxpupuli#654, though continues to allow the user to set the package via $rabbitmqadmin_package
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Mar 30, 2022
Archlinux integration tests were failing because of rabbitmqadmin not being present. It seems that, while the package exists, it is in the "community" repo. Partially rolls back voxpupuli#654, though continues to allow the user to set the package via $rabbitmqadmin_package
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Mar 30, 2022
Archlinux integration tests were failing because of rabbitmqadmin not being present. It seems that, while the package exists, it is in the "community" repo. Update Python package name to python instead of python2 Partially rolls back voxpupuli#654, though continues to allow the user to set the package via $rabbitmqadmin_package
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Mar 30, 2022
Update Python package name to python instead of python2, and use file install vs. package install by default Partially rolls back voxpupuli#654, though continues to allow the user to set the package via $rabbitmqadmin_package
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Jun 17, 2022
Update Python package name to python instead of python2, and use file install vs. package install by default Partially rolls back voxpupuli#654, though continues to allow the user to set the package via $rabbitmqadmin_package
wyardley
added a commit
that referenced
this pull request
Jun 17, 2022
Update Python package name to python instead of python2, and use file install vs. package install by default Partially rolls back #654, though continues to allow the user to set the package via $rabbitmqadmin_package
wyardley
added a commit
that referenced
this pull request
Nov 14, 2024
Update Python package name to python instead of python2, and use file install vs. package install by default Partially rolls back #654, though continues to allow the user to set the package via $rabbitmqadmin_package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.