Avoid error when rabbitmqctl is not present), update spec syntax (#614) #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
approved these changes
Sep 6, 2017
alexjfisher
reviewed
Sep 6, 2017
| expect(Facter.fact(:rabbitmq_nodename).value).to eq('monty@rabbit1') | ||
| } | ||
| end |
alexjfisher
reviewed
Sep 6, 2017
| expect(Facter.fact(:rabbitmq_nodename).value).to eq('monty@rabbit-1') | ||
| end | ||
| end | ||
|
|
…and update spec syntax
wyardley
force-pushed
the
make_facter_more_tolerant
branch
from
36942f9 to
98118c4
Compare
bastelfreak
approved these changes
Sep 6, 2017
This was referenced Sep 6, 2017
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
Avoid error when rabbitmqctl is not present), update spec syntax (voxpupuli#614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to 'expect' style rspec syntax, and switch to
Facter::Util::Resolution(vsExecution), thanks @dhollinger