Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 'contain' vs. anchor pattern, and use Class['foo'] vs Class['::foo'] #613

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 6, 2017

Update class ordering to follow current best practices.

This also removes some apparently redundant uses of require => Class['rabbitmq::install']

@wyardley wyardley force-pushed the change_class_scope branch 2 times, most recently from 159d4d4 to e916267 Compare September 6, 2017 19:16
@wyardley
Copy link
Contributor Author

wyardley commented Sep 6, 2017

Unless we get rid of puppet-lint-absolute_classname-check in Gemfile, we'll have to use
contain '::rabbitmq::foo'
vs
contain rabbitmq::foo

@wyardley wyardley force-pushed the change_class_scope branch 3 times, most recently from 7b50c0d to d97f552 Compare September 6, 2017 19:34
@alexjfisher alexjfisher merged commit f209e76 into voxpupuli:master Sep 7, 2017
@wyardley wyardley deleted the change_class_scope branch September 9, 2017 23:29
slm0n87 pushed a commit to slm0n87/puppet-rabbitmq that referenced this pull request Mar 7, 2019
Switch to 'contain' vs. anchor pattern, and use Class['foo'] vs Class['::foo']
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
Switch to 'contain' vs. anchor pattern, and use Class['foo'] vs Class['::foo']
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants