fix a couple of problems with erl_ssl_path fact #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costela
force-pushed
the
fix_erl_ssl_path
branch
from
6f36f27 to
e9beac3
Compare
- with_env got dropped in facter >=3, so stop using it. - only call gsub if actually run; This should avoid "undefined method `gsub!' for false:FalseClass" - add simple test
costela
force-pushed
the
fix_erl_ssl_path
branch
from
e9beac3 to
a2ba372
Compare
wyardley
changed the title
|
@wyardley Yes, this is now fixed. |
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
fix a couple of problems with erl_ssl_path fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is a re-submission of #606)
Hi there,
This small PR fixes two small issues with the
erl_ssl_pathfact.The first is pretty straightforward: avoid the
.gsubcall if we didn't actually get any data to mangle.The second is a bit less clear-cut: drop the use of
.with_envwhile callingerl. Newer versions of facter (>=3) AFAIK stopped supporting it (compare 2.x docs with 3.x docs) and it was unclear why we needed it in the first place. If I'm missing something and it is needed in some case, I'd be happy to find another workaround.It also adds simple testing for
erl_ssl_path.Cheers