Convert to use 'archive' instead of 'staging' for rabbitmqadmin install #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
commented
Sep 5, 2017
| wget_option => '--no-proxy --no-check-certificate', | ||
| require => [ | ||
| archive { 'rabbitmqadmin': | ||
| path => "${rabbitmq::rabbitmq_home}/rabbitmqadmin", |
There was a problem hiding this comment.
Not sure if it's better to update this to just stage it, drop it in its final destination upon successful retrieval, and then clean up the tmp file vs. having the file resource?
There was a problem hiding this comment.
I think the current behavior is totally valid
bastelfreak
approved these changes
Sep 5, 2017
apevec
pushed a commit
to redhat-openstack/rdoinfo
that referenced
this pull request
Sep 28, 2017
Puppet module archive is a new dependency for puppet-rabbitmq after [1] New package review in https://bugzilla.redhat.com/show_bug.cgi?id=1496870 [1] voxpupuli/puppet-rabbitmq#604 Change-Id: Ibf875f44df2b8684c62f43a1e8e4a36b84238b31
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
Convert to use 'archive' instead of 'staging' for rabbitmqadmin install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the module to use the 'archive' module instead of 'staging'.