Eliminate more "multiple expectations" warnings and remove some redundant specs #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
commented
Sep 4, 2017
| expect(policy[:definition]['ha-params']).to be_a(Array) | ||
| expect(policy[:definition]['ha-params'][0]).to eq('rabbit@rabbit-01') | ||
| expect(policy[:definition]['ha-params'][1]).to eq('rabbit@rabbit-02') | ||
| context 'accepts list value in ha-params when ha-mode = nodes' do |
There was a problem hiding this comment.
I think this works Ok here, but not sure if there's a better way to do it.
alexjfisher
reviewed
Sep 4, 2017
|
|
||
| it do | ||
| expect(policy[:definition]['ha-mode']).to eq('nodes') | ||
| end |
There was a problem hiding this comment.
I might be tempted to use a single line for each of these?
ie.
it { expect(policy[:definition]['ha-mode']).to eq('nodes') }
There was a problem hiding this comment.
Will do. You think moving the outer bit to a context makes sense here though?
There was a problem hiding this comment.
Updated, btw, if you want to re-review
wyardley
force-pushed
the
multiple_expectations2
branch
from
7b0ebd4 to
4bf585c
Compare
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
Eliminate more "multiple expectations" warnings and remove some redundant specs
cegeka-jenkins
pushed a commit
to cegeka/puppet-rabbitmq
that referenced
this pull request
Mar 26, 2021
Eliminate more "multiple expectations" warnings and remove some redundant specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would appreciate feedback on this one.