Switch to rspec-puppet-facts #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
reviewed
Aug 31, 2017
| require 'rspec-puppet-facts' | ||
| include RspecPuppetFacts | ||
| # Original fact sources: | ||
| add_custom_fact :puppetversion, Puppet.version # Facter, but excluded from rspec-puppet-facts |
There was a problem hiding this comment.
Is there a more up to date way to include these (maybe in spec/default_module_facts.yaml)?
There was a problem hiding this comment.
after a modulesync, puppetversion will be set. staging:http_get can be set via spec/default_module_facts.yml
wyardley
approved these changes
Aug 31, 2017
There was a problem hiding this comment.
Looks good to me! 👍 Thanks for the contribution.
Hoping @bastelfreak or @alexjfisher can also review.
bastelfreak
reviewed
Aug 31, 2017
| let(:params) { { repos_ensure: true } } | ||
| has_systemd = ( | ||
| (facts[:osfamily] == 'RedHat' && facts[:os]["release"]["major"].to_i >= 7) || | ||
| (facts[:osfamily] == 'Debian' && facts[:os]["release"]["full"] == '16.04') |
There was a problem hiding this comment.
can you add archlinux here as well?
There was a problem hiding this comment.
I will add arch suport in a separate PR
|
Did introduce some rubocop warnings, which I'll fix while rebasing #580 |
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
Switch to rspec-puppet-facts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.