Fix error text in rabbitmq_vhost provider
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures unrelated to the PR change: https://travis-ci.org/voxpupuli/puppet-rabbitmq/jobs/245405735 |
|
Reopened to retrigger tests. |
hunner
added a commit
that referenced
this pull request
Aug 10, 2017
Fix error text in `rabbitmq_vhost` provider
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
Fix error text in `rabbitmq_vhost` provider
cegeka-jenkins
pushed a commit
to cegeka/puppet-rabbitmq
that referenced
this pull request
Mar 26, 2021
Fix error text in `rabbitmq_vhost` provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small thing that threw me when looking through the code.
This provider is definitely calling
rabbitmqctl -q list_vhosts, so if that output can't be parsed it should complain about invalid vhost lines, rather than invalid user lines.Looks like a copy-paste error from other similar providers.
This will improve user experience when they encounter this error.