(maint) parallel_spec maintenance: spec_helper #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the parallel_spec that is run on travis revealed a dependency issue in the user_permissions_spec. none of the type unit tests were using the spec_helper and were requiring puppet and their respective types explicitly. this reverses that by requiring the spec_helper and removing the other dependencies and in turn repairing the failures.
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
(maint) parallel_spec maintenance: spec_helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the parallel_spec that is run on travis revealed a dependency issue in the user_permissions_spec. none of the type unit tests were using the spec_helper and were requiring puppet and their respective types explicitly. this reverses that by requiring the spec_helper and removing the other dependencies and in turn repairing the failures.
this is causing travis to fail needlessly on all PRs currently.