Update apt::source to match with new method #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this require a bump in metadata.json, or will it still work with apt 1.8.0? |
|
@hunner yes, but 2.x.x has been released in 2015-04. I suppose people update their manifests from time to time? Maybe I'm wrong. Feel free to merge it or not. FWIW, Puppet OpenStack CI is running 2.2.x serie: |
|
I want to merge this, but it would require a 6.0.0 release of rabbitmq. While we're at it, what other changes do we want to make to the module? |
|
Could you also increase the lower bound of puppetlabs-apt in metadata.json to >= 2.0.0? Since it won't work with 1.8.x |
|
@hunner done |
|
👍 |
|
hi @EmilienM , could you please rebase? |
|
@eputnam done. |
puppetlabs-apt recently did some changes that brings warnings when we
run puppetlabs-rabbitmq, because we need to update the way we consume
apt module.
$include_src is deprecated and will be removed in the next major
release, please use $include => { 'src' => false } instead
$key_source is deprecated and will be removed in the next major release,
please use $key => { 'source' =>
http://www.rabbitmq.com/rabbitmq-signing-key-public.asc } instead.
This patch aims to update the way we use puppetlabs-apt to match with
upstream and avoid warnings in our catalog.
Also bump puppetlabs-apt to >= 2.0.0.
|
Merged in #497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs-apt recently did some changes that brings warnings when we
run puppetlabs-rabbitmq, because we need to update the way we consume
apt module.
$include_src is deprecated and will be removed in the next major
release, please use $include => { 'src' => false } instead
$key_source is deprecated and will be removed in the next major release,
please use $key => { 'source' =>
http://www.rabbitmq.com/rabbitmq-signing-key-public.asc } instead.
This patch aims to update the way we use puppetlabs-apt to match with
upstream and avoid warnings in our catalog.