Disallow empty string in package_apt_pin
#1025
Merged
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nil
instead of empty string in test for empty pinResolves a test failure that seems to have cropped up since the last time tests ran (probably a new version of the apt module).
This is technically breaking in a minor way, though guessing we don't need to cut a major for it. Alternately, I could continue to be less strict in the module's validation, and just update the test case 🤷