-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idempotency issue with implicitly enabled plugins #930
Labels
bug
Something isn't working
Comments
wyardley
pushed a commit
to wyardley/puppet-rabbitmq
that referenced
this issue
May 11, 2023
Rabbitmq_plugin now correctly detects implicitly enabled plugins to preserve idempotency regardless of plugin install order Cherry-picked from voxpupuli#844 Fixes voxpupuli#930 Signed-off-by: William Yardley <[email protected]>
wyardley
pushed a commit
to wyardley/puppet-rabbitmq
that referenced
this issue
May 11, 2023
Rabbitmq_plugin now correctly detects implicitly enabled plugins to preserve idempotency regardless of plugin install order Cherry-picked from voxpupuli#844 Fixes voxpupuli#930 Signed-off-by: William Yardley <[email protected]>
wyardley
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
May 11, 2023
wyardley
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
May 11, 2023
wyardley
pushed a commit
that referenced
this issue
Nov 14, 2024
Rabbitmq_plugin now correctly detects implicitly enabled plugins to preserve idempotency regardless of plugin install order Cherry-picked from #844 Fixes #930 Signed-off-by: William Yardley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rabbitmq_plugin
was retrieving a list of existing plugins by querying for "explicitly" enabled plugins using the
rabbitmq-plugin -E` command. This caused us issues when adding support for CentOS/RHEL8 where we noticed that in this mode, ordering of plugins matters.Example of the scenario we saw:
In this spec test: https://github.com/voxpupuli/puppet-rabbitmq/blob/master/spec/acceptance/parameter_spec.rb#L18
The following plugins are declared:
The
rabbitmq_federation_management
plugin depends onrabbitmq_federation
, so when our code enablesrabbitmq_federation_management
it will automatically enablerabbitmq_federation
, but mark it as being "implicitly" enabled because it was enabled as a result of enablingrabbitmq_federation_management
.Then, when go to query for the list of enabled plugins using the
-E
option, this only lists our "explicitly" enabled plugins, sorabbitmq_federation
is never listed and every time we run Puppet it attempts to enable the plugin, breaking idempotency.Copied this text from @nmaludy's #844, but creating an issue as well, just for tracking purposes.
This also implements a different fix for what was originally fixed in #909
The text was updated successfully, but these errors were encountered: