use Optional instead of Variant[Undef... #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
reviewed
Oct 20, 2017
manifests/nginx_vts_exporter.pp
Outdated
| String $bin_dir = $::prometheus::params::bin_dir, | ||
| String $nginx_scrape_uri = $::prometheus::params::nginx_vts_exporter_nginx_scrape_uri, | ||
| String $download_extension = $::prometheus::params::nginx_vts_exporter_download_extension, | ||
| Optional[String] $download_url = undef, |
There was a problem hiding this comment.
This looks good to me, but if you're going to line up the params, I think you need one more space here? Or, alternately, do what most modules do, and don't align the second column (though to me, this actually is easier to read).
I think if it's >= Puppet 4, you can also go back to $prometheus vs $::prometheus if you like (the former is actually preferred now).
There was a problem hiding this comment.
thanks for the input. fixed
wyardley
approved these changes
Oct 20, 2017
|
@TheMeier Could you squash those 2 commits? Thanks. |
align indentation switch from $::prometheus... to $prometheus...
|
squashed |
|
@TheMeier Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
use Optional instead of Variant[Undef...
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
use Optional instead of Variant[Undef...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align indentation