fix default scrape_uri in apache_exporter #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default scrape_uri in the prometheus apache exporter actually has a trailing slash. This matters because somehow, here, the address without a trailing slash fails to scrape. The default is documented here: https://github.com/Lusitaniae/apache_exporter/blob/83d8e4d2003eaa85c754d12c110e0a7757e78143/apache_exporter.go#L30 Unit tests adjusted to match change.
bastelfreak
approved these changes
Feb 24, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Mar 11, 2024
fix default scrape_uri in apache_exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default scrape_uri in the prometheus apache exporter actually has
a trailing slash. This matters because somehow, here, the address
without a trailing slash fails to scrape.
The default is documented here:
https://github.com/Lusitaniae/apache_exporter/blob/83d8e4d2003eaa85c754d12c110e0a7757e78143/apache_exporter.go#L30
Unit tests adjusted to match change.