deploy env_file_path on server #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, when the install_method is set to `package` and
init_style is set to `none`, the various `prometheus::server` settings
will never do anything because we stop touching the systemd config
file.
By deploying the env_file_path on the server, we allow the "Debian
package" setup (install_method=package and init_style=none) to
propagate the daemon_flags correctly.
By default, the Debian systemd.service file has this entry:
EnvironmentFile=/etc/default/prometheus
ExecStart=/usr/bin/prometheus $ARGS
... which makes it use the ARGS define in the "default" config
file.
This is a subset of voxpupuli#303, which should hopefully pass tests and be
more manageable.
Closes: voxpupuli#323
anarcat
force-pushed
the
env-file-server-323
branch
from
dba5624 to
305e9ac
Compare
This was referenced Feb 23, 2021
Closed
bastelfreak
approved these changes
Feb 24, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Mar 11, 2024
deploy env_file_path on server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, when the install_method is set to
packageandinit_style is set to
none, the variousprometheus::serversettingswill never do anything because we stop touching the systemd config
file.
By default, the Debian systemd.service file has this entry:
... which makes it use the ARGS define in the "default" config
file. This is a hack, but it works on our side in production.
Closes: #323
This is a subset of #303, which should hopefully pass tests and be more manageable.
See also #32