Implement unbound_exporter #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
previously requested changes
Sep 26, 2020
alexjfisher
reviewed
Dec 3, 2020
| # @param init_style | ||
| # Service startup scripts style (e.g. rc, upstart or systemd) | ||
| # @param install_method | ||
| # Installation method: url or package (only url is supported currently) |
There was a problem hiding this comment.
Is url supported? Or it is if URL is to a local mirror where you've built the binary??
Maybe include an @example Installing from your own package repository or something based on how you're currently using this?
There was a problem hiding this comment.
at the moment I compiled the binary by myself and copied it into /usr/local/bin/unbound_exporter. I was hoping that letsencrypt/unbound_exporter#21 will be solved soon. That would enable this class to download the exporter from there. maybe we should keep this PR open until they provide proper releases.
alexjfisher
approved these changes
Dec 3, 2020
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Mar 11, 2024
Implement unbound_exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues