Added redis_exporter module #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It installs https://github.com/oliver006/redis_exporter which seems to be the most used redis exporter for Prometheus. It uses prometheus::daemon although I had to redefine the archive extraction code in the exporter class due to packaging differences.
bastelfreak
reviewed
Jun 29, 2017
| # [*version*] | ||
| # The binary release version | ||
| class prometheus::redis_exporter ( | ||
| $addr = $::prometheus::params::redis_exporter_redis_address, |
There was a problem hiding this comment.
can you add puppet4 datatypes to the parameters?
bastelfreak
reviewed
Jun 29, 2017
| $release = "v${version}" | ||
|
|
||
| $real_download_url = pick($download_url, "${download_url_base}/download/${release}/${package_name}-${release}.${os}-${arch}.${download_extension}") | ||
| validate_bool($purge_config_dir) |
There was a problem hiding this comment.
you can drop these validate_* calls, they're deprecated and replaced by datatypes
|
ping @vide |
|
Sorry @bastelfreak still on 3.8 at work so I have to setup Puppet 4 to write and test the code, and currently have very little spare time :( |
yackushevas
added a commit
to yackushevas/puppet-prometheus
that referenced
this pull request
Feb 12, 2018
clone from voxpupuli#45 (added puppet4 datatypes and drop validate_* calls)
|
Duplicated by #157 |
|
Hi @vide and @bastelfreak , I've created this PR #224 to use "redis.file" parameter as default for this exporter. Hope this could helps! |
|
Hi, |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
clone from voxpupuli#45 (added puppet4 datatypes and drop validate_* calls)
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
clone from voxpupuli#45 (added puppet4 datatypes and drop validate_* calls)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It installs https://github.com/oliver006/redis_exporter which
seems to be the most used redis exporter for Prometheus.
It uses prometheus::daemon although I had to redefine the archive
extraction code in the exporter class due to packaging differences.