Add bin_name override to daemon.pp #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dudemcbacon Thanks for the PR. Looks like a reasonable addition. Would you be able to look at the test failures and then squash your commits? ( |
|
Rubocop'ed and squashed. Thanks! |
alexjfisher
approved these changes
Dec 9, 2018
|
@dudemcbacon Thanks! |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Add bin_name override to daemon.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I have added a bin_name parameter to daemon.pp for cases where you'd like to specifically set the name of the binary that should be executed in the init script rather than relying on the $name supplied to the define type.
This Pull Request (PR) fixes the following issues
This fixes an issue where running multiple instances of an exporter is not possible because changing the name $title of the define type also changes the name of the binary that is executed by the init script. I need to be able to run 8 instances of the mongodb_exporter on a single host because I have eight instances of mongodb running on that host.