-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysv, armv6/7 fixes #270
sysv, armv6/7 fixes #270
Conversation
Hi @defenestration, thanks for the PR! Can you take a look at the failing spec tests? |
I added additional commits to hopefully resolve the ruby tests, which seem to just complain about using double quotes in strings without variables. |
…l arch with armv6 packages
The code looks fine and I'm unable to reproduce the issue locally. I rebased your branch. Let's see if this works now. |
Now we have an actual failure. Can you please take a look at the travis issues? |
@bastelfreak I think we need to update the fixtures, because the parameter
|
I edited the file that the tests use to compare against, removing the -log.format option, which seems to have been the only issue. One of the travis builds failed due to apt timing out, but I think it will pass if it is retried, which i can't seem to do. |
I restarted the failed job |
Support for ARMv5, 6 and 7 was already merged, there are double entries now in init.pp! puppet-prometheus/manifests/init.pp Line 186 in 492d18f
|
ups. Will provide a patch for this. |
sysv, armv6/7 fixes
sysv, armv6/7 fixes
Pull Request (PR) description
This adds support for armv6/7 releases.
Also on cent6 the 'service_provider' fact gets detected as 'redhat', added fixes to use this like sysv provider.
This Pull Request (PR) fixes the following issues
Fixes #268
Fixes #265