use service name for redis_exporter to prevent multiple downloads of redis_exporter #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blupman could you create a little acceptance test like this one: https://github.com/voxpupuli/puppet-prometheus/blob/master/spec/acceptance/prometheus_exporter_spec.rb to verify that the exporter now works? |
since it might already be running removed test for absence of prometheus-server
|
I have updated the pull request to contain an acceptance test |
|
Thanks @blupman ! |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
use service name for redis_exporter to prevent multiple downloads of redis_exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
use service name for redis_exporter to prevent multiple downloads of redis_exporter, as described in issue #215.
I also created a $install_dir variable to prevent errors and de-duplicate some code.
This Pull Request (PR) fixes the following issues
Fixes #215
Regards,
Niels