Merge pull request #201 from bastelfreak/defaults

migrate more default values to hiera

data/defaults.yaml

@@ -1,5 +1,16 @@
 ---
 prometheus::configname: 'prometheus.yaml'
+prometheus::service_enable: true
+prometheus::service_ensure: 'running'
+prometheus::manage_service: true
+prometheus::restart_on_change: true
+prometheus::init_style: '%{facts.service_provider}'
+prometheus::extra_options: ''
+prometheus::download_url: ~
+prometheus::arch: '%{facts.architecture}'
+prometheus::manage_group: true
+prometheus::purge_config_dir: true
+prometheus::manage_user: true
 prometheus::bin_dir: '/usr/local/bin'
 prometheus::version: '1.5.2'
 prometheus::install_method: 'url'

manifests/init.pp

@@ -159,21 +159,21 @@
   String $storage_retention,
   Stdlib::Absolutepath $env_file_path,
   Boolean $manage_prometheus_server,
-  Hash $extra_alerts             = {},
-  Boolean $service_enable        = true,
-  String $service_ensure         = 'running',
-  Boolean $manage_service        = true,
-  Boolean $restart_on_change     = true,
-  String $init_style             = $facts['service_provider'],
-  String $extra_options          = '',
-  Hash $config_hash              = {},
-  Hash $config_defaults          = {},
-  String $os                     = downcase($facts['kernel']),
-  Optional[String] $download_url = undef,
-  String $arch                   = $facts['architecture'],
-  Boolean $manage_group          = true,
-  Boolean $purge_config_dir      = true,
-  Boolean $manage_user           = true,
+  Boolean $service_enable,
+  String $service_ensure,
+  Boolean $manage_service,
+  Boolean $restart_on_change,
+  String $init_style,
+  String $extra_options,
+  Optional[String] $download_url,
+  String $arch,
+  Boolean $manage_group,
+  Boolean $purge_config_dir,
+  Boolean $manage_user,
+  Hash $extra_alerts    = {},
+  Hash $config_hash     = {},
+  Hash $config_defaults = {},
+  String $os            = downcase($facts['kernel']),
 ) {
 
   case $arch {