Fix path for crl_auto_renew with easy_rsa 3.0

[cible]

Pull Request (PR) description

Small patch to fix the path of crl.pem introduced by #432 by @jkroepke
The cp fail with :

'./easyrsa gen-crl && cp ./keys/crl.pem /etc/openvpn/10.9.200.0 255.255.255.0/crl.pem' returned 1 instead of one of [0]
change from 'notrun' to ['0'] failed: './easyrsa gen-crl && cp ./keys/crl.pem /etc/openvpn/10.9.200.0 255.255.255.0/crl.pem' returned 1 instead of one of [0] (corrective)

Certainly a cut and paste problem. In manifests/revoke.pp, $server is the correct variable but not in server.pp

[root-expert]

Thanks!

[jkroepke]

Consider to add an test case for this. :)

[jkroepke]

@cible in fact you have to test if the puppet exec with command correct exists.

puppet-openvpn/spec/defines/openvpn_server_spec.rb

Line 479 in fe0e82d

it { is_expected.to contain_exec('renew crl.pem on test_server') }

With exec resource itself is already including. The command parameter needs to be added, like (just an example):

it { is_expected.to contain_exec('renew crl.pem on test_server').with('command' => './easyrsa gen-crl && cp ./keys/crl.pem /etc/openvpn/server/crl.pem') } } 

In worse, an additional condition for easy-rsa 2.0 and 3.0 is needed

[cible]

Sorry, I'm pretty bad with those kind of tests. Does it look good for you, now?

[jkroepke]

lgtm

[smortex]

Looks good! Can you please combine your 7 commits in a single one?

From your working directory:

git rebase -i 2b2168e796a58a851b13431e438a6fbf24b8d69f # Interactively rewrite history

This will bring your editor listing all your commits. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will pop again and allow you to combine all the commit messages in a single one.

Then push your updated branch:

git push -f            # Send the changes (-f is required because we re-wrote history)