Update code to set status parameter optional #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Oct 15, 2020
|
Would be nice to also have a test for this. |
|
I am not an expect with puppet and/or ruby but I can try ... |
In this file https://github.com/voxpupuli/puppet-openvpn/blob/master/spec/defines/openvpn_server_spec.rb you want to have a test that verifies that the |
smutel
force-pushed
the
SetStatusOptional
branch
from
70789be to
ae1ecd5
Compare
|
I added one test. Tell me if it's ok. |
kenyon
force-pushed
the
SetStatusOptional
branch
from
ae1ecd5 to
5dce685
Compare
kenyon
approved these changes
Oct 18, 2020
|
Do you plan to create a new tag soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently the openvpn option called status is mandatory and set with /var/log/openvpn/${name}-status.log as default.
However this parameter is not mandatory in the openvpn config. If this parameter is omitted, every log will be append to openvpn.log.