Fixes #374 - Revocation command update and crl renew #375
Conversation
Rubueno
force-pushed
the
revokefix
branch
2 times, most recently
from
add3ec3 to
3bfa748
Compare
|
@bastelfreak could you have a look at this? |
|
I'm not very familiar with openvpn. Any chance to add an acceptance test for this? |
Rubueno
force-pushed
the
revokefix
branch
16 times, most recently
from
8442a18 to
b6920df
Compare
|
@bastelfreak An acceptance test is written and tests valid. I've cleaned up the way the revoked client file is managed. The test I wrote succeeds, but it's failing on another part which I didn't touch, which also seems to fail on a clean fork from master. |
|
ah, this pulls in a broken version of facter and is fixed in https://github.com/voxpupuli/puppet-openvpn/pull/380/files - but that introduced another error. we will have a look and come back to you. |
|
might be fixed with #381 |
|
I'll subscribe to #381, I'll rebase to see if it's fixed then |
|
looks good, please rebase :) |
|
@bastelfreak Unsure why it's failing so massively now. Would it help to rerun the CI jobs? |
|
This was caused by the beaker 4.23.0 release: https://rubygems.org/gems/beaker |
|
Cheers. Seems all is good but it's not reflected back here. |
An issue was raised informing that the revocation command is incorrect. This was diagnosed to indeed be the case. As the `$name` variable in context of `revoke.pp` does not evalute to `server name` but instead `client name`. The exec for the crl renew was updated to clarify which server it's done for and to prevent duplicate `exec` resource names. `catch_changes` in the acceptance test was taken out because a crl renew is triggrered which is seen as a change.
An issue was raised informing that the revocation command is incorrect.
This was diagnosed to indeed be the case. As the
$namevariable incontext of
revoke.ppdoes not evalute toserver namebut insteadclient name. The exec for the crl renew was updated to clarify which serverit's done for and to prevent duplicate
execresource names.Fixes #374