Only output ldap_tls_client_cert_file and ldap_tls_client_key_file when set #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en set TLSCertFile and TLSKeyFile are not always required, especially if no client certificates are used (also see the docs linked below). If they are set to empty values, the plugin throws an exception/parser error. Thus, only put them in the config file when they are actually used. References: https://github.com/threerings/openvpn-auth-ldap/wiki/Configuration Signed-off-by: Florian Pritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLSCertFile and TLSKeyFile are not always required, especially if no
client certificates are used (also see the docs linked below). If they
are set to empty values, the plugin throws an exception/parser error.
Thus, only put them in the config file when they are actually used.
References:
https://github.com/threerings/openvpn-auth-ldap/wiki/Configuration
Signed-off-by: Florian Pritz [email protected]