Add scripts with server

[yakatz]

Pull Request (PR) description

This change allows packaging scripts with the server instance.

Example usage:

openvpn::server { 'test-site':
    ....
    up => '/etc/openvpn/test-site/scripts/add-tap-to-bridge.sh',
    scripts => {
        "add-tap-to-bridge.sh" => {content => 'a'},
    },
}

Anything that can go in a regular Puppet file resource can be used in the hash including template, source, and content.

up, down, client-connect and client-disconnect scripts will be checked for / and be considered to be in the scripts folder otherwise.

Tests pass locally.

[yakatz]

Build failure looks like an infrastructure issue, not test issue

[Dan33l]

Build failure looks like an infrastructure issue, not test issue

I restarted the job.

[bastelfreak]

@yakatz please have a look at the inline comments I made. Can you also document this feature in the README.md?

[bastelfreak]

Ping @yakatz

[yakatz]

For some reason I didn't get notifications from GitHub about this. I will work on it over the next few days.

[pccibot]

Dear @yakatz, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[yakatz]

Looks like a test timeout again. Is this something I am doing wrong or is it just a test system issue?

[yakatz]

Once again, test failures look to me to be infrastructure issues. There is nothing changed in the last commit that would change the outcome of these tests.

[Dan33l]

Once again, test failures look to me to be infrastructure issues. There is nothing changed in the last commit that would change the outcome of these tests.

On failing configuration, the vpnserver system under test does not see the vpn client.
On working configuration:
https://travis-ci.org/voxpupuli/puppet-openvpn/jobs/604083503#L2210
On failing configuration
https://travis-ci.org/voxpupuli/puppet-openvpn/jobs/604083491#L2134

Right now i am unable to say more.

[bastelfreak]

@yakatz the code looks good to me. Are you able to squash the commits down to a few?

[yakatz]

@bastelfreak Squashed to 2

[yakatz]

@bastelfreak Any thought on when this could make it into a release?