add acceptance tests with real vpn client/server setup #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dan33l
changed the title
Dan33l
force-pushed
the
multinode_acceptance
branch
4 times, most recently
from
5d43d36 to
3cb0b5f
Compare
Dan33l
force-pushed
the
multinode_acceptance
branch
from
3cb0b5f to
23ced8a
Compare
Dan33l
changed the title
alexjfisher
requested changes
Oct 25, 2018
README.md
Outdated
|
|
||
| ## Dependencies | ||
| - [puppetlabs-concat 3.0.0+](https://github.com/puppetlabs/puppetlabs-concat) | ||
| - [puppetlabs-stdlib 4.25.0+](https://github.com/puppetlabs/puppetlabs-stdlib) | ||
|
|
||
| ## Puppet | ||
|
|
||
| * Version >= 4.7.1 | ||
| * Version >= 4.25.0 |
There was a problem hiding this comment.
I updated the README and saw this is not uptodate with metadata.json
alexjfisher
reviewed
Oct 25, 2018
README.md
Outdated
|
|
||
| Note : TLS ciphers suites shipped with OSes ubuntu14.04 and debian8 are too old compared to our default values. | ||
| If these OSes hosts the server with clients more moderns, you will probably have to use custom value for option `tls_cipher`. |
There was a problem hiding this comment.
This sentence doesn’t read too well.
spec/acceptance/openvpn_spec.rb
Outdated
| index_path = '/etc/openvpn/test_openvpn_server/easy-rsa/keys' | ||
| end | ||
|
|
||
| # All-terrain tls ciphers are used to be able to works with all supported OSes. |
spec/acceptance/openvpn_spec.rb
Outdated
| end | ||
|
|
||
| # All-terrain tls ciphers are used to be able to works with all supported OSes. | ||
| # Default value is with ciphers too recents for old OSes like ubuntu 14.04. |
There was a problem hiding this comment.
‘recent’ instead of ‘recents’
Dan33l
force-pushed
the
multinode_acceptance
branch
from
3b378b4 to
9afc6df
Compare
alexjfisher
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Creates a client / server setup with SUT. This permit to make more tests.
This Pull Request (PR) fixes the following issues