update supported OSes in params.pp

[Dan33l]

Pull Request (PR) description

update params.pp to be up to date with current metadata.json

This Pull Request (PR) fixes the following issues

Fixes #291

[bastelfreak]

structured facts \o/

[bastelfreak]

suggestion for future enhancements: $systemd can be set to true if the fact [service_provider](https://github.com/puppetlabs/puppetlabs-stdlib#service_provider) returns systemd

[bastelfreak]

this should be migrated to rspec-puppet-facts, same applies for the other spec files.

[Dan33l]

You're right, but the tag needs-work was not useless.
I did it.

[bastelfreak]

Did you test if this is required? We have mocked facts here:

puppet-openvpn/spec/default_facts.yml

Line 11 in 9f3abf6

concat_basedir: "/tmp"

And use them here:

puppet-openvpn/spec/spec_helper.rb

Lines 25 to 35 in 9f3abf6

	RSpec.configure do |c|
	default_facts = {
	puppetversion: Puppet.version,
	facterversion: Facter.version
	}
	default_facts.merge!(YAML.load(File.read(File.expand_path('../default_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_facts.yml', __FILE__))
	default_facts.merge!(YAML.load(File.read(File.expand_path('../default_module_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_module_facts.yml', __FILE__))
	c.default_facts = default_facts
	c.mock_with :rspec
	c.hiera_config = 'spec/fixtures/hiera/hiera.yaml'
	end

[bastelfreak]

If I see this correctly this PR doesnt add support for new operating systems, right? Otherwise the list in the metadata.json needs to be updated as well.

[bastelfreak]

I created a little patch that you might want to look into:

diff --git a/spec/classes/openvpn_config_spec.rb b/spec/classes/openvpn_config_spec.rb
index 10b4e73..d33e35d 100644
--- a/spec/classes/openvpn_config_spec.rb
+++ b/spec/classes/openvpn_config_spec.rb
@@ -4,12 +4,12 @@ describe 'openvpn::config', type: :class do
   on_supported_os.each do |os, facts|
     context "on #{os}" do
       let(:facts) do
-        facts.merge(
-          concat_basedir: '/var/lib/puppet/concat'
-        )
+        facts
       end
 
-      case facts[:os][:family]
+      it { is_expected.to compile.with_all_deps }
+
+      case facts[:os]['family']
       when 'Debian'
         context 'on Debian based machines' do
           it { is_expected.to contain_concat('/etc/default/openvpn') }

A couple of things:

• I tested this, we don't need to mock concat_basedir
• in the facts hash, only the first key is a symbol, all further nested keys are strings
• It's always good to check if the manifest compiles into a catalog

[Dan33l]

If I see this correctly this PR doesnt add support for new operating systems, right? Otherwise the list in the metadata.json needs to be updated as well.

Exactly . No new OS.

[bastelfreak]

facts hash \o/

[bastelfreak]

thanks for this awesome PR!