Add crl renewal #256
Merged
Add crl renewal #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 3, 2018
manifests/server.pp
Outdated
| @@ -497,6 +511,9 @@ | |||
| $rcvbuf = undef, | |||
| $shared_ca = undef, | |||
| $crl_verify = true, | |||
| $crl_auto_renew = false, | |||
There was a problem hiding this comment.
Can you add datatypes for the new params?
There was a problem hiding this comment.
Shure, if you want me to do that - i did not, since none of the params has datatypes yet...
There was a problem hiding this comment.
yeah, we want to have datatypes for all new params
|
Hi @to-kn, thanks for the PR. Can you take a look at hte inline comment and the failing spec tests? |
|
Hi @bastelfreak the tests should be finde now. (the first one failing has nothing to do with the code). anything else? |
|
Can you rebase please? I fixed the travis error in #257 (maybe) |
|
looks good! (they passed...) |
|
@to-kn can you rebase please? Afterwards I can merge it. |
to-kn
force-pushed
the
add_crl_renewal
branch
2 times, most recently
from
6e038c4 to
1744d5b
Compare
add parameters: crl_auto_renew, crl_renew_schedule_period, crl_renew_schedule_repeat fix spec-tests
bastelfreak
reviewed
Jan 5, 2018
| @@ -497,6 +511,9 @@ | |||
| Optional[Integer] $rcvbuf = undef, | |||
| Optional[String] $shared_ca = undef, | |||
| Boolean $crl_verify = true, | |||
| Boolean $crl_auto_renew = false, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a solution to the Problem described in #236
Had in running in production for ~half a year now, with no problems...
Included some basic tests - feel free, to suggest any change or anything else