Add parameter to allow setting error_log severity level #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you don't like that this patch will add the severity level to nginx.conf, I can modify it to only add it if severity level is set by the user intentionally. Personally I think setting default values in configurations files enhance readability. |
|
Hi @jfryman We have a dependency on this as we transition to using your awesome module. Could you please take a look at this PR? |
|
LGTM. Thanks for the code! |
jfryman
added a commit
that referenced
this pull request
Nov 2, 2015
Add parameter to allow setting error_log severity level
|
Thank you James and Phil! |
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Add parameter to allow setting error_log severity level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to set the severity level for error_log.
If not set it will use the default severity level of 'error'.
$nginx_error_log_severity is validated to only allow valid values.