Rip back out puppet-module-data #501
Conversation
… rip-out-module-data
| include nginx | ||
| class { 'nginx::config': | ||
| gzip => false, | ||
| } |
There was a problem hiding this comment.
nginx::config is already declared in nginx class so this would result in a duplicate declaration error.
There was a problem hiding this comment.
I added some logic in another branch that covered this that I didn't 🍒-pick and put here. I've grabbed that.
|
I think this is for the best for now. Though with this change it looks like if a user just does |
| $_daemon_user = 'http' | ||
| } | ||
| 'Debian': { | ||
| $_pid = 'www-data' |
There was a problem hiding this comment.
should be $_daemon_user = 'www-data'
This is the good part about the |
| $global_owner = $nginx::params::global_owner, | ||
| $global_group = $nginx::params::global_group, | ||
| $global_mode = $nginx::params::global_mode, | ||
| $log_dir = $nginx::params::log_dir, |
There was a problem hiding this comment.
Parameter in this class should be logdir to match the old name.
There was a problem hiding this comment.
I did consider this... this is the only variable that didn't seem to match the existing style in the rest of code. I'll put another deprecation warning to make it less painful.
There was a problem hiding this comment.
HA! It actually looks like you did that already. 🙇
| $worker_connections = 1024, | ||
| $worker_processes = 1, | ||
| $worker_rlimit_nofile = 1024, | ||
| ### END Nginx Configuration ### | ||
| ) { |
There was a problem hiding this comment.
Do we need to inherit nginx::params here?
…et-nginx into rip-out-module-data
… rip-out-module-data Conflicts: docs/hiera.md
Rip back out puppet-module-data
As part of merging #501, default values for config.pp were integers. However, many of the current logic expects to see strings for many values. This commit fixes things up while the validation logic can be adjusted to take account integer.
As part of merging voxpupuli#501, default values for config.pp were integers. However, many of the current logic expects to see strings for many values. This commit fixes things up while the validation logic can be adjusted to take account integer.
Well, it was a nice idea in #453, but there have been several reported issues with the update.
puppet-module-dataadds extra time to catalog compilation.puppet-module-data. It has proven to be hacky enough to cause errors in several edge cases. Because it is not part of Puppet Core, it increases the barrier to entry for a fair number of folks.I love this pattern, but it need a lot of love, and until it becomes a first class citizen, it needs to be ripped out before we hit 1.0. So, while I hate making a big change and then ripping it out... it's better to do now than before it becomes too unwieldy.