Enabled undef for service where we dont want puppet control service

[zdenekjanda]

In cases, where nginx is managed within cluster by pacemaker, we need this module not to manage the service by default, although we would like to send it restart notifications on config changes. Therefore 'undef' string can be send, which will then get evaluated and properly send to service class not to manage it.

[jfryman]

I am confused why 'undef' is being passed as a string and not a bareword... it would make https://github.com/jfryman/puppet-nginx/pull/319/files#diff-9253f3c9cbffa1500f41d4db2baa8664R30-R35 entirely unnecessary.

[zdenekjanda]

You set a default when undef is received to the module, so it will be replaced with your params.pp default running, that will force service to start. So, your module starts it, then corosync stops it on standby node, and so on cycle. The point is you keep managing notify when changing config files, which really works well when undef is passed to ensure - when service is running, it will get notification, if not it will simply pass, entirely compatible with 3rd party management such as Corosync. Tickets at Puppetlabs to enlight this: https://projects.puppetlabs.com/issues/22580 and https://projects.puppetlabs.com/issues/22587#note-2

[jfryman]

TIL. OK! Thanks for the add!