Introduce two new optional proxy parameters #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 6, 2018
manifests/resource/location.pp
Outdated
| @@ -217,6 +220,8 @@ | |||
| Optional[String] $proxy_http_version = undef, | |||
| Optional[String] $proxy_set_body = undef, | |||
| Optional[Enum['on', 'off']] $proxy_buffering = undef, | |||
| Optional[String] $proxy_max_temp_file_size = undef, | |||
There was a problem hiding this comment.
Can you please use Optional[String[1]] here please?
There was a problem hiding this comment.
There is a size datatype, which should be used in my opinion.
https://github.com/voxpupuli/puppet-nginx/blob/master/types/size.pp
We want to be able to manage the configuration values of: proxy_busy_buffers_size and proxy_max_temp_file_size
bastelfreak
force-pushed
the
new_proxy_paramaters
branch
from
cd19cc2 to
f30a773
Compare
|
I added the datatype and will merge it after travis turns green. |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Introduce two new optional proxy parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
We want to be able to manage the following (optional) configuration values:
proxy_busy_buffers_size
proxy_max_temp_file_size
With this PR user can modify the above values inside the location-block and also in the main nginx.conf.
This Pull Request (PR) fixes the following issues
Fixes #1176